8000 Add port attribute to Connection object · Issue #96 · tableau/document-api-python · GitHub
[go: up one dir, main page]
Skip to content

Add port attribute to Connection object #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
geordielad opened this issue Oct 16, 2016 · 2 comments
Closed

Add port attribute to Connection object #96

geordielad opened this issue Oct 16, 2016 · 2 comments
Assignees
@t8y8
Labels
enhancement
Milestone
2016.10 release (...

Comments

@geordielad
Copy link

Can we add the port attribute to connection. This might be useful before the full document API is implemented. Some datasource changes could need to change the port in addition to the server etc. Some changes are a bit more involved but could include a port change. For example migrating from AWS RDS Postgres to Redshift might mean changing port from 5432 to 5439. A change of database variant could require other changes of course - schema in the relation for example.
@t8y8 t8y8 self-assigned this Oct 16, 2016
@t8y8
Copy link
Contributor
t8y8 commented Oct 16, 2016

I've got a patch for this but I need to confirm the semantics of port='' vs no port attribute and when they're valid or not.

@t8y8 t8y8 mentioned this issue Oct 17, 2016
Merged
t8y8 added a commit that referenced this issue Oct 17, 2016
@t8y8
Issue #96: Add port support (#97)
1aa4fc0 
Issue #96: Add port support

We now support reading and setting the port attribute on connections. If you set the port attribute to None it will remove it entirely. Small change to tests so that they don't have side effects between test cases.
@t8y8
Copy link
Contributor
t8y8 commented Oct 17, 2016 •
edited
Loading

@geordielad ask and ye shall receive. Enjoy!

Closed in #97

@t8y8 t8y8 closed this as completed Oct 17, 2016
@graysonarts graysonarts added this to the 2016.10 release (v0.5) milestone Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t8y8 t8y8

Labels
enhancement
Projects
None yet
Milestone
2016.10 release (v0.5)
Development

No branches or pull requests
3 participants
@graysonarts @geordielad @t8y8
0