8000 fix: show tab bar on savings and spending screens by jvsena42 · Pull Request #751 · synonymdev/bitkit-android · GitHub
[go: up one dir, main page]
Skip to content

fix: show tab bar on savings and spending screens #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jvsena42 merged 1 commit into from
Jan 30, 2026
Merged

fix: show tab bar on savings and spending screens #751

jvsena42 merged 1 commit into from
Jan 30, 2026

Conversation

@jvsena42
Copy link
Member
@jvsena42 jvsena42 commented Jan 29, 2026 •
edited
Loading

Fixes #696

This PR fixes the missing Send and Receive buttons on the Savings and Spending activity screens.

Description

When navigating to the Savings or Spending balance screens, the tab bar (containing Send and Receive buttons) was not visible. This was because the tab bar visibility logic only included the Home and AllActivity routes. This PR adds the Savings and Spending routes to the list of screens where the tab bar should be displayed.

Preview

Screen_recording_20260129_124425.webm

QA Notes

1. Savings screen tab bar

  1. Open the wallet
  2. Tap on Savings balance
  3. Verify the tab bar with Send and Receive buttons is visible at the bottom

2. Spending screen tab bar

  1. Open the wallet
  2. Tap on Spending balance
  3. Verify the tab bar with Send and Receive buttons is visible at the bottom

3. Regression - Home and Activity screens

  1. Verify tab bar still appears on Home screen
  2. Verify tab bar still appears on All Activity screen

@jvsena42 jvsena42 self-assigned this Jan 29, 2026
@jvsena42 jvsena42 requested a review from ovitrif January 29, 2026 15:48
@claude
Copy link
claude bot commented Jan 29, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@jvsena42 jvsena42 enabled auto-merge January 29, 2026 23:14
ovitrif
ovitrif approved these changes Jan 30, 2026
View reviewed changes
Copy link
Collaborator
@ovitrif ovitrif left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

nit: We may not need .qualifiedName, .simpleName might be enough but it's definitely not as safe mid-term, until we get the nav3 migration done.

@jvsena42 jvsena42 merged commit 7d21133 into master Jan 30, 2026
13 checks passed
@jvsena42 jvsena42 deleted the fix/tab-bar-visibility branch January 30, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ovitrif ovitrif ovitrif approved these changes

Assignees

@jvsena42 jvsena42

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Send and Receive buttons are missing after one taps on spending or savings balance

3 participants

@jvsena42 @ovitrif
0