8000 maint(ci): add 3.12 prerelease testing and bump versions by oscarbenjamin · Pull Request #24776 · sympy/sympy · GitHub
[go: up one dir, main page]
Skip to content

maint(ci): add 3.12 prerelease testing and bump versions #24776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2023
Merged

maint(ci): add 3.12 prerelease testing and bump versions #24776

merged 1 commit into from
Feb 26, 2023
+28 −21

Conversation

oscarbenjamin
Copy link
Collaborator
@oscarbenjamin oscarbenjamin commented Feb 24, 2023 •
edited
Loading

References to other Issues or PRs

Issue to track the release of 1.12: #24601

Brief description of what is fixed or changed

Add Python 3.12 prerelease testing.

Bump default Python version in CI to 3.11.

Also change benchmark comparison to compare master against the 3.12 release branch as the "previous release".

Other comments

Release Notes

NO ENTRY

@oscarbenjamin oscarbenjamin added the Releasing Issues relating to the automated release scripts. Use milestones to block issues on a release. label Feb 24, 2023
@sympy-bot
Copy link
sympy-bot commented Feb 24, 2023 •
edited
Loading

✅

Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.
Click here to see the pull request description that was parsed. 
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->

Issue to track the release of 1.12: #24601

#### Brief description of what is fixed or changed

Add Python 3.12 prerelease testing.

Bump default Python version in CI to 3.11.

Also change benchmark comparison to compare master against the 3.12 release branch as the "previous release".

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers. Formerly, `log(-x)` incorrectly gave `-log(x)`.

* physics.units
  * Corrected a semantical error in the conversion between volt and statvolt which
    reported the volt as being larger than the statvolt.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@oscarbenjamin oscarbenjamin mentioned this pull request Feb 24, 2023
Closed
44 tasks
@oscarbenjamin oscarbenjamin reopened this Feb 24, 2023
This was referenced Feb 24, 2023
Merged
Closed
@oscarbenjamin oscarbenjamin reopened this Feb 25, 2023
@oscarbenjamin
Copy link
Collaborator Author

There seems to be some other problem causing tests1 to fail under Python 3.12. I'm not sure what it is but the tests just end with:

sympy/diffgeom/tests/test_class_structure.py[3] ...                         [OK]
sympy/diffgeom/tests/test_diffgeom.py[16] ..........
Error: Process completed with exit code 1.

I don't immediately have 3.12 alpha to test with locally.

@oscarbenjamin oscarbenjamin mentioned this pull request Feb 25, 2023
Closed
@oscarbenjamin
Copy link
Collaborator Author

There seems to be some other problem causing tests1 to fail under Python 3.12.

This is a segfault. Running the tests in a subprocess hides the message that should be shown: Segmentation fault: 11. I can reproduce this locally on OSX.

I've opened a CPython issue:
python/cpython#102250

This was referenced Feb 25, 2023
Closed
Open
@oscarbenjamin
Copy link
Collaborator Author

I've opened a CPython issue:
python/cpython#102250

I've confirmed that this is a CPython bug so I'm just going to mark the CPython 3.12 job as not being required to pass. That means that it won't be necessary for that job to pass in order to merge a PR but we will still see if it fails. Hopefully it will get fixed when CPython 3.12 alpha 6 is released (expected Monday, 2023-03-06).

@oscarbenjamin oscarbenjamin merged commit 75691e5 into sympy:master Feb 26, 2023
@oscarbenjamin oscarbenjamin deleted the pr_python_312 branch February 26, 2023 11:54
This was referenced Feb 26, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Releasing Issues relating to the automated release scripts. Use milestones to block issues on a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oscarbenjamin @sympy-bot
0