8000 minor #59764 Fixes XliffFileDumperTest for 6.4 (Hanmac) · symfonyaml/symfony@5e433ee · GitHub
[go: up one dir, main page]
Skip to content

Commit 5e433ee

Browse files
nicolas-grekasnicolas-grekas
committed
minor symfony#59764 Fixes XliffFileDumperTest for 6.4 (Hanmac)
This PR was squashed before being merged into the 6.4 branch. Discussion ---------- Fixes XliffFileDumperTest for 6.4 Fix Id Hash | Q | A | ------------- | --- | Branch? | 6.4 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Commits ------- 7b9968e Fixes XliffFileDumperTest for 6.4
2 parents 2a5e399 + 7b9968e commit 5e433ee

File tree

2 files changed

+2
-20
lines changed

2 files changed

+2
-20
lines changed

‎src/Symfony/Component/Translation/Tests/Dumper/XliffFileDumperTest.php

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -148,24 +148,6 @@ public function testDumpCatalogueWithXliffExtension()
148148
);
149149
}
150150

151-
public function testFormatCatalogueXliff2WithSegmentAttributes()
152-
{
153-
$catalogue = new MessageCatalogue('en_US');
154-
$catalogue->add([
155-
'foo' => 'bar',
156-
'key' => '',
157-
]);
158-
$catalogue->setMetadata('foo', ['segment-attributes' => ['state' => 'translated']]);
159-
$catalogue->setMetadata('key', ['segment-attributes' => ['state' => 'translated', 'subState' => 'My Value']]);
160-
161-
$dumper = new XliffFileDumper();
162-
163-
$this->assertStringEqualsFile(
164-
__DIR__.'/../Fixtures/resources-2.0-segment-attributes.xlf',
165-
$dumper->formatCatalogue($catalogue, 'messages', ['default_locale' => 'fr_FR', 'xliff_version' => '2.0'])
166-
);
167-
}
168-
169151
public function testEmptyMetadataNotes()
170152
{
171153
$catalogue = new MessageCatalogue('en_US');

‎src/Symfony/Component/Translation/Tests/Fixtures/resources-2.0-empty-notes.xlf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<xliff xmlns="urn:oasis:names:tc:xliff:document:2.0" version="2.0" srcLang="fr-FR" trgLang="en-US">
33
<file id="messages.en_US">
4-
<unit id="Ll7LrI6" name="empty">
4+
<unit id="Lhz6grA" name="empty">
55
<segment>
66
<source>empty</source>
77
<target>notes</target>
88
</segment>
99
</unit>
10-
<unit id="hU8PAYC" name="full">
10+
<unit id="oYuGmy6" name="full">
1111
<notes>
1212
<note category="file-source" priority="1">test/path/to/translation/Example.1.html.twig:27</note>
1313
</notes>

0 commit comments

Comments
 (0)
0