8000 Fixes XliffFileDumperTest for 6.4 by Hanmac · Pull Request #59764 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fixes XliffFileDumperTest for 6.4 #59764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

Fixes XliffFileDumperTest for 6.4 #59764

merged 1 commit into from
Feb 13, 2025

Conversation

Hanmac
Copy link
Contributor
@Hanmac Hanmac commented Feb 13, 2025

Fix Id Hash

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #...
License MIT

@Hanmac Hanmac requested a review from welcoMattic as a code owner February 13, 2025 10:00
@carsonbot carsonbot added this to the 6.4 milestone Feb 13, 2025
@Hanmac
Copy link
Contributor Author
Hanmac commented Feb 13, 2025 •
edited
Loading

@nicolas-grekas should fix the faulty ids

and other tests are green too

@Hanmac Hanmac changed the title Update resources-2.0-empty-notes.xlf Fixes XliffFileDumperTest for 6.4 Feb 13, 2025
@nicolas-grekas
Copy link
Member

Thank you @Hanmac.

@nicolas-grekas nicolas-grekas merged commit 5e433ee into symfony:6.4 Feb 13, 2025
8 of 9 checks passed
@Hanmac Hanmac deleted the patch-1 branch February 13, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welcoMattic welcoMattic Awaiting requested review from welcoMattic welcoMattic is a code owner

Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Hanmac @nicolas-grekas @carsonbot
0