8000 Escape pipes in markdown tables by stof · Pull Request #54 · symfony-tools/symfony-translation-checker · GitHub
[go: up one dir, main page]

Skip to content

Escape pipes in markdown tables #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Escape pipes in markdown tables #54

merged 1 commit into from
Jan 14, 2025

Conversation

stof
Copy link
Member
@stof stof commented Jan 14, 2025

The | character needs to be escaped to avoid being treated as a cell delimiter in the markdown table when dealing with pluralized messages.

The `|` character needs to be escaped to avoid being treated as a cell delimiter in the markdown table when dealing with pluralized messages.
@stof stof requested a review from Nyholm January 14, 2025 12:53
@stof
Copy link
Member Author
stof commented Jan 14, 2025

Discovered in symfony/symfony#59409:

image

Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit fc8d6df into master Jan 14, 2025
2 of 3 checks passed
@Nyholm Nyholm deleted the stof-patch-1 branch January 14, 2025 12:55
@stof
Copy link
Member Author
stof commented Jan 14, 2025

Too bad you merged it with a red CI. I was about to amend the PR to fix it.

@OskarStark OskarStark changed the title Ecape pipes in markdown tables Escape pipes in markdown tables Jan 14, 2025
@Nyholm
Copy link
Member
Nyholm commented Jan 14, 2025

Ah, Sorry. I was a bit too quick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0