This repository was archived by the owner on Sep 16, 2021. It is now read-only.
(DoctrinePHPCRBundle) Document details of mapping options #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference from doctrine orm bundle
dbu
reviewed
Nov 19, 2018
|
Thanks for the feedback! I have updated the PR accordingly now. Please can you have another look? |
dbu
approved these changes
Nov 20, 2018
|
thanks a lot. i will now merge the 1.3 branch to master to keep that in sync. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the change in doctrine/DoctrinePHPCRBundle#330, which removes an incorrect hard-coded application level mapping, mappings config becomes necessary in most cases. To offer easier setup, the config usage needs to be documented in more detail. This PR references from doctrine orm bundle to complete the mapping option details.
This PR applies to all maintained versions and therefore it is not necessary to wait until doctrine/DoctrinePHPCRBundle#330 becomes ready and gets merged.