Add cmf_find_translation twig function documentation #769
Conversation
bundles/core/templating.rst
Outdated
|
|
||
| * **cmf_find|find(path)**: Get the document for the provided path or null if not found. | ||
| No publish workflow check is done. | ||
| * **cmf_find_translation|findTranslation(($path, $locale, $fallback = true)**: Get the document translation |
There was a problem hiding this comment.
duplicated opening (
and can we call the paramter $pathOrDocument to be more explicit?
ed74246 to
e4d058f
Compare
|
sorry, one last thing: we should have a versionadded block after the list of twig functions that says in which version we added this function. otherwise users of an older version will be confused. (for the exact syntax, look for ..versionadded: in the doc sources, we use that in several places) |
|
version would be 1.3.1 of the core bundle |
e4d058f to
5598a40
Compare
|
No problem, is it ok like this ? |
|
sorry, no the doc should be in the table with the others. the versionadded just explains when this particular function has been added. like "The cmf_find_translation twig function has been added in version 1.3.1 of the CMF CoreBundle." |
5598a40 to
8ea2576
Compare
|
Ho sorry, I just fixed it, hope it's ok now ! |
|
yep, that 7270 was the idea. thank you! |
@dbu Related to symfony-cmf/core-bundle#201