8000 refacto: extract WSL check fron symfony-cli/console package by tucksaun · Pull Request #568 · symfony-cli/symfony-cli · GitHub
[go: up one dir, main page]
Skip to content

refacto: extract WSL check fron symfony-cli/console package #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2025
Merged

refacto: extract WSL check fron symfony-cli/console package #568

merged 1 commit into from
Feb 17, 2025

Conversation

tucksaun
Copy link
Member

I believe this check should not be part of the symfony-cli/console package as it is not generic and displays a warning about the Symfony CLI binary

See symfony-cli/console#22

@tucksaun
refacto: extract WSL check fron symfony-cli/console package
716eb38 
I believe this check should not be part of the symfony-cli/console package as it is not generic and display a warning about the Symfony CLI binary
@tucksaun tucksaun requested a review from fabpot February 15, 2025 11:28
@fabpot fabpot merged commit 7096a0b into symfony-cli:main Feb 17, 2025
1 check passed
@tucksaun tucksaun deleted the refacto/wsl-checks branch May 16, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot Awaiting requested review from fabpot

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tucksaun @fabpot
0