8000 Rework database URL precedence by fabpot · Pull Request #434 · symfony-cli/symfony-cli · GitHub
[go: up one dir, main page]
Skip to content

Rework database URL precedence #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2024
Merged

Rework database URL precedence #434

merged 1 commit into from
Feb 9, 2024

Conversation

fabpot
Copy link
Contributor
@fabpot fabpot commented Feb 9, 2024

Here is the algo:

  • If on a Platform.sh container or if a local tunnel is open to the remote Platform.sh service, check if the version is set in doctrine.yaml configuration as it can be more precise than the Platform.sh version (only major.minor)
  • If on Docker locally, read the version from Docker API (the version is very precise, so we don't care about the Doctrine configuration)

@fabpot fabpot merged commit dbe6914 into main Feb 9, 2024
@fabpot fabpot deleted the database-url-precedence branch February 9, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fabpot
0