Add support for a docker_compose worker and prioritize its startup
#370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2bd90c9 to
c76c262
Compare
|
Not entirely ready yet: I encounter a bunch of "no such process" error when exiting but I'm not sure where they come from |
|
Actually, I get the "no such process" on |
|
Can be rebased |
e25d762 to
549bdbf
Compare
|
@fabpot rebased |
|
Thank you @tucksaun |
|
@tucksaun will this work to expose the environment variables of docker services to the PHP server as well or is this worker still starting too late for that ? |
|
@stof the PHP server determines the variables on every request so this should work out-of-the box |
|
Thanks @tucksaun for this awesome feature 👏 |
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 7, 2023
…jmsche) This PR was submitted for the 6.4 branch but it was merged into the 5.4 branch instead. Discussion ---------- [Symfony CLI] Document the new docker_compose option See symfony-cli/symfony-cli#370 Commits ------- 142ce5f [Symfony CLI] Document the new docker_compose option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should fix #240.
based on #308
The idea is that when this specific worker is configured it will block the start up of other workers.
Also to be "sure" services are up we do the startup in a two-step process:
docker compose up -dwhich will return only once services are updocker compose upinstead, which will block until we stop the server and will stop the containers when being stopped