8000 Add docker image by shyim · Pull Request #206 · symfony-cli/symfony-cli · GitHub
[go: up one dir, main page]
Skip to content

Add docker image #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2022
Merged

Add docker image #206

merged 3 commits into from
Nov 4, 2022

Conversation

shyim
Copy link
Contributor
@shyim shyim commented Oct 31, 2022 •
edited
Loading

To improve #205

@shyim
Copy link
Contributor A 8000 uthor
shyim commented Oct 31, 2022 •
edited
Loading

i guess you to have to release it first time manually to give the CI access. See package settings as example

image

@shyim shyim changed the title Add docker Add docker image Oct 31, 2022
@tucksaun
Copy link
Member

@shyim I will probably have a couple of suggestions to make.
do you prefer a PR to your fork or suggestions directly within this PR?

@shyim
Copy link
Contributor Author
shyim commented Oct 31, 2022 •
edited
Loading

image
You should be able to push directly in my branch if you are maintainer :)

git push -u https://github.com/shyim/symfony-cli.git

@tucksaun
Copy link
Member

@shyim hehe but I'm not maintainer 😆

@fabpot
Copy link
Contributor
fabpot commented Oct 31, 2022

@tucksaun Looks like you've just been promoted ;)

@tucksaun
Copy link
Member
tucksaun commented Nov 3, 2022

@fabpot @shyim I just pushed some fixes and tweaks.

@fabpot: do not merge it yet though because GitHub actions are not running gorelease build for PR (working on it), so we can't be sure yet everything works properly on the CI.

@tucksaun
Copy link
Member
tucksaun commented Nov 3, 2022

this will fix #101 as well

@tucksaun tucksaun mentioned this pull request Nov 3, 2022
Merged
@tucksaun tucksaun force-pushed the add-docker branch 2 times, most recently from 85dc3a4 to 95ec143 Compare November 4, 2022 16:40
@tucksaun tucksaun requested a review from fabpot November 4, 2022 16:51
@tucksaun
Copy link
Member
tucksaun commented Nov 4, 2022

I added multiarch support, TLS certificates into the image so that external communications (new version checking, security checks, etc) work and tried to optimize to get the least layers possible.

And the CI is green, we will need to see how first release on GHCR works though.

@shyim @fabpot ready for review I guess.

@fabpot fabpot merged commit 8a46133 into symfony-cli:main Nov 4, 2022
@tucksaun tucksaun mentioned this pull request Nov 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot Awaiting requested review from fabpot

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shyim @tucksaun @fabpot
0