10000 JSON Schema for .symfony.local.yaml · Issue #236 · symfony-cli/symfony-cli · GitHub
[go: up one dir, main page]
Skip to content

JSON Schema for .symfony.local.yaml #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shyim opened this issue Nov 28, 2022 · 5 comments
Closed

JSON Schema for .symfony.local.yaml #236

shyim opened this issue Nov 28, 2022 · 5 comments

Comments

@shyim
Copy link
Contributor
shyim commented Nov 28, 2022

I hate looking into docs to find out how the config file is structured. For this reason I would suggest creating a simple JSON schema for that file and submitting to https://www.schemastore.org/json/

So when someone creates that file, the editor autopickups the configuration and shows completion. :)

I can create the PR to add a schema and help getting into schemastore if wanted
@fabpot
Copy link
Contributor
fabpot commented Nov 28, 2022

This is an undocumented feature :) And one that was never announced. So, it's sort of hidden in the code.
That's because I'm not fully satisfied with the way it works and I might change it drastically at some point.

@shyim
Copy link
Contributor Author
shyim commented Nov 28, 2022

It is a little bit documented here :) https://symfony.com/doc/current/setup/symfony_server.html#configuring-workers

I would like to extend the config using PR's. Like defining the php-fpm max_children and so as it is currently hard-code :)

@fabpot
Copy link
Contributor
fabpot commented Nov 28, 2022

Arf, didn't see the related PR.
@javiereguiluz Can you mark this feature as experimental in the docs?

@javiereguiluz javiereguiluz mentioned this issue Nov 28, 2022
Merged
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this issue Nov 29, 2022
@javiereguiluz
minor symfony#17475 Mark some Symfony CLI feature as experimental (ja…
222cda0 
…viereguiluz)

This PR was merged into the 4.4 branch.

Discussion
----------

Mark some Symfony CLI feature as experimental

As asked by `@fabpot` in symfony-cli/symfony-cli#236 (comment)

Commits
-------

1d78eb9 Mark some Symfony CLI feature as experimental
@javiereguiluz
Copy link
Contributor

We can close this as fixed in symfony/symfony-docs#17475

@tucksaun
Copy link
Member
tucksaun commented Dec 6, 2022

Thank you @javiereguiluz

I'm closing this one for now as I don't think publishing an "official" JSON schema for an experimental feature makes sense.
Let's reassess if and when the feature is stabilized.

@tucksaun tucksaun closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @javiereguiluz @tucksaun @shyim
0