10000 Detect PHP version from system %PATH% variable by rnapoles · Pull Request #21 · symfony-cli/phpstore · GitHub
[go: up one dir, main page]
Skip to content

Detect PHP version from system %PATH% variable #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Detect PHP version from system %PATH% variable #21

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
104718e
Detect PHP version from system %PATH% variable
rnapoles Mar 9, 2025
c8836df
Update discovery_windows.go
rnapoles Mar 10, 2025
f06cd98
Update discovery_windows.go
rnapoles Mar 10, 2025
f35e8ff
Update discovery_windows.go
rnapoles Mar 10, 2025
2e6b58c
Fix: remove unused "runtime" import
rnapoles Mar 28, 2025
ff873c9
Fix symfony-cli/phpstore#16
rnapoles Mar 28, 2025
bcfc131
Merge branch 'symfony-cli:main' into main
rnapoles May 8, 2025
73bf1d0
Merge branch 'symfony-cli:main' into main
rnapoles May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions discovery_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ package phpstore

import (
"os"
"os/exec"
"path/filepath"
"regexp"
)
Expand All @@ -30,6 +31,9 @@ func (s *PHPStore) doDiscover() {
systemDir := systemDir()
userHomeDir := userHomeDir()

// %PATH%
s.addFromPath()

// XAMPP
s.addFromDir(filepath.Join(systemDir, "xampp", "php"), nil, "XAMPP")

Expand All @@ -53,12 +57,28 @@ func (s *PHPStore) doDiscover() {
}
}

func systemDir() string {
cwd, err := os.Getwd()
func (s *PHPStore) addFromPath() {

phpPath, err := exec.LookPath("php.exe")
if err != nil {
return
}

dir := filepath.Dir(phpPath)
if v := s.discoverPHP(dir, "php"); v != nil {
s.addVersion(v)
}

}

func systemDir() string {

val, ok := os.LookupEnv("SystemDrive")
if !ok {
return "C:\\"
}
return filepath.VolumeName(cwd) + "\\"

return val + string(os.PathSeparator)
}

func userHomeDir() string {
Expand Down
0