8000 [Site][Toolkit] Add manual installation steps for Component installation (and some website tweaks) by Kocal · Pull Request #2716 · symfony/ux · GitHub
[go: up one dir, main page]

Skip to content

[Site][Toolkit] Add manual installation steps for Component installation (and some website tweaks) #2716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2025

Conversation

Kocal
Copy link
Member
@Kocal Kocal commented May 6, 2025
Q A
Bug fix? no
New feature? no
Docs? yes
Issues Fix #...
License MIT

Another PR started in the plane :D

IMG_2736 - copie


This one add manual installation steps in the documentation, letting people see files they will install before (or without) installing the UX Toolkit:

Enregistrement.de.l.ecran.2025-05-06.a.18.29.57.mov

@carsonbot carsonbot added Site ux.symfony.com Toolkit Status: Needs Review Needs to be reviewed labels May 6, 2025
Comment on lines +175 to +183
// @media screen and (min-width: 768px) {
// .Terminal_content::-webkit-scrollbar {
// display: none;
// }
// .Terminal_content {
// --webkit-scrollbar-width: none;
// scrollbar-width: none;
// }
// }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this one, but I don't really see why you would want to hide a scrollbar, as it reduce accessibility and UX

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related to Toolkit ? Any page i can see the problem ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and no, I wanted to display a scroll bar when necessary, but I couldn't understand why this code exists.
You can check the "Alert" component page, by unfolding the files from "manual installation" section, it contains a Terminal with a veryyy long and unbreakable line.

You can also check other parts of the website where a Terminal is displayed, to confirm it didn't break things. 🙏

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it broke things at a time, two scrollbars were displayed. Testing on mac often gives a false impression, as macOS hide scrollbars per default.

But let's see and we will be able to fix if there were any pb

👍 :

@Kocal Kocal requested review from smnandre and kbond May 6, 2025 10:21
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels May 6, 2025
Copy link
Member
@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Kocal Kocal force-pushed the toolkit/installation-manual-steps branch from b33c8e5 to b454358 Compare May 7, 2025 15:01
… to render the highlighted code inside a Terminal component
@Kocal Kocal force-pushed the toolkit/installation-manual-steps branch from b454358 to 948abe5 Compare May 7, 2025 15:21
@Kocal Kocal merged commit 58b0eb2 into symfony:2.x May 7, 2025
3 of 4 checks passed
@Kocal Kocal deleted the toolkit/installation-manual-steps branch May 7, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site ux.symfony.com Status: Reviewed Has been reviewed by a maintainer Toolkit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0