-
-
Notifications
You must be signed in to change notification settings - Fork 360
[Site][Toolkit] Add manual installation steps for Component installation (and some website tweaks) #2716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
// @media screen and (min-width: 768px) { | ||
// .Terminal_content::-webkit-scrollbar { | ||
// display: none; | ||
// } | ||
// .Terminal_content { | ||
// --webkit-scrollbar-width: none; | ||
// scrollbar-width: none; | ||
// } | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this one, but I don't really see why you would want to hide a scrollbar, as it reduce accessibility and UX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this related to Toolkit ? Any page i can see the problem ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes and no, I wanted to display a scroll bar when necessary, but I couldn't understand why this code exists.
You can check the "Alert" component page, by unfolding the files from "manual installation" section, it contains a Terminal with a veryyy long and unbreakable line.
You can also check other parts of the website where a Terminal is displayed, to confirm it didn't break things. 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it broke things at a time, two scrollbars were displayed. Testing on mac often gives a false impression, as macOS hide scrollbars per default.
But let's see and we will be able to fix if there were any pb
👍 :
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
…umentation tabs rendering into ToolkitService
b33c8e5
to
b454358
Compare
… to render the highlighted code inside a Terminal component
b454358
to
948abe5
Compare
Another PR started in the plane :D
This one add manual installation steps in the documentation, letting people see files they will install before (or without) installing the UX Toolkit:
Enregistrement.de.l.ecran.2025-05-06.a.18.29.57.mov