[StimulusBundle] Make the JS package private #2709
Conversation
|
Can you explain the scenario where there is a problem ? I'm not sure to follow here. AFAIK, for AssetMapper there is no problem, as it is not concerned with renovate. For webpack, the bridge deals with all this (on the project i'm working on, renovate works perfectly), and there is no entry for stimulus-bundle in the package.json |
|
It's all explained here #2708 (comment), where the It's a temporary solution to prevent more issues.
Yes, but here we are talking about users that don't use Encore, but the AssetMapper and importmap (with |
Packages have been published on npm to resolve the path problem in packages.json, preventing renovate/github action to work. With asset mapper, not using packages.json this is not a problem. Also, this situation should never happen IRL so let's not take to much time / energy on this :) |
…Kocal) This PR was merged into the 2.x branch. Discussion ---------- [StimulusBundle] Make the JS package private (for real) | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Following #2709 and failing checks like https://github.com/symfony/ux/actions/runs/14850493570/job/41693038644?pr=2713 Commits ------- 625bf5e [StimulusBundle] Make the JS package private (for real)
This PR follows #2708
The npm package
@symfony/stimulus-bundlewas accidentally published on npm when I was working on the "Symfony UX on NPM" project, but when I realized it was to late to unpublish it.Today, I was able to unpublish the package from npm. I'm now making the package private, so it won't be released anymore (until a solution is implemented)
I would be very happy to re-publish this package again when #2708 (comment) will be fixed.