[Map] Render map from Twig with ux_map() and <twig:ux:map />
#2117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
reviewed
Sep 1, 2024
|
See #2152 as a lighter (but not complete yet) alternative |
|
Yeah i'll use the fromArray static from your PR and we'll see... but i hope this will simplify a lot this one. Thanks ! |
606594b to
553e49b
Compare
|
Integrated the ideas fom #2152 |
ux_map() + Add <twig:ux:map/> TwigComponentux_map() and <twig:ux:map />
Kocal
reviewed
Sep 12, 2024
Kocal
reviewed
Sep 12, 2024
| */ | ||
| public static function fromArray(array $point): self | ||
| { | ||
| if (isset($point['lat'], $point['lng'])) { |
There was a problem hiding this comment.
Suggested change
| if (isset($point['lat'], $point['lng'])) { | |
| if ($point['lat'] ?? null && $point['lng'] ?? null) { |
so we can allow users to pass 0 as lat/lng
There was a problem hiding this comment.
$pos = ['lat' => 0, 'lng' => 0];
echo isset($pos['lat'], $pos['lng']);
# 1The only case would be $pos = [0, 0] and i don't mind that much 😅
Kocal
approved these changes
Sep 12, 2024
Kocal
approved these changes
Sep 14, 2024
| use Symfony\UX\TwigComponent\TwigComponentBundle; | ||
|
|
||
| /** | ||
| * @internal |
There was a problem hiding this comment.
Do we need to mark test files internal?
4422a2f to
92f89d3
Compare
|
Thanks @smnandre for working on this feature, this is much appreciated. |
|
Thanks @Kocal for the help / suggestions / feedback ❤️ I'll add doc asap, but I now can work on demos with twig content, and i think it's gonna be more effective to showcase the component! |
symfony-splitter
pushed a commit
to symfony/ux-map
that referenced
this pull request
Nov 4, 2024
This PR was squashed before being merged into the 2.x branch. Discussion ---------- [Map] Update documentation First round of changes, very open to feedback / suggestions (it's a draft to start iterating) related: symfony/ux#2117 Commits ------- 9eb85399a [Map] Update documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add an MapFactory (internal)ux_mapTwig function to render map from named arguments<twig:ux:map ... />Create Map from Twig
{{ ux_map( center: [51.5074, 0.1278], zoom: 3, markers: [ { position: [51.5074, 0.1278], title: 'London' }, { position: [48.8566, 2.3522], title: 'Paris' }, { position: [40.7128, -74.0060], title: 'New York', infoWindow: { content: 'Welcom to <b>New York</b>' } }, ], attributes: { class: 'foo', style: 'height: 800px; width: 100%; border: 4px solid red; margin-block: 10vh;', } ) }}