8000 Adding support for AssetMapper 6.4 to StimulusBundle, etc by weaverryan · Pull Request #1240 · symfony/ux · GitHub
[go: up one dir, main page]
Skip to content

Adding support for AssetMapper 6.4 to StimulusBundle, etc #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2023
Merged

Adding support for AssetMapper 6.4 to StimulusBundle, etc #1240

merged 1 commit into from
Nov 2, 2023

Conversation

weaverryan
Copy link
Member
@weaverryan weaverryan commented Oct 29, 2023 •
edited
Loading
Q A
Bug fix? yes
New feature? no
Issues None
License MIT

Change for AssetMapper 6.4 support. This is 2 main things:

A) Changes needed after symfony/symfony#52349 with removal of trait + absolute import paths
B) Outputting autoimport via {{ importmap() }} function / deprecate ux_controller_link_tags().

TODO:

  • I still need to the React/Svelte/Vue support to double-check it's all good for both 6.3 and 6.4.
  • Finish lazy autoimport
  • Make sure controllers.json is properly a config cache file resource for appropriate files

Cheers!

@weaverryan weaverryan changed the title Adding support for AssetMapper 6.4 with removal of trait + absolute import paths Adding support for AssetMapper 6.4 Oct 29, 2023
@weaverryan weaverryan mentioned this pull request Nov 1, 2023
Closed
@weaverryan
Copy link
Member Author

This is ready :). It keeps BC with AssetMapper 6.3 so we can release a StimulusBundle before 6.4. Then we'll drop 6.3 support.

@tacman
Copy link
Contributor
tacman commented Nov 2, 2023

Is there a way to test in a project? It looks like your branch is in the monorepo, but not pushed to symfony/asset-mapper, so I'm not sure how to require that branch.

@weaverryan
Copy link
Member Author

Yup - you can test by following this - https://github.com/symfony/ux#contributing (obviously, pull down my fork, switch into the branch, then run that link command)

@weaverryan weaverryan force-pushed the asset-mapper-64-import-path-change branch from 0d043b5 to 05bcb98 Compare November 2, 2023 19:55
@weaverryan weaverryan merged commit 2991b06 into symfony:2.x Nov 2, 2023
@weaverryan weaverryan changed the title Adding support for AssetMapper 6.4 Adding support for AssetMapper 6.4 to StimulusBundle, etc Nov 2, 2023
@weaverryan weaverryan deleted the asset-mapper-64-import-path-change branch November 3, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weaverryan @tacman
0