8000 configure strict_requirements: null in production by Tobion · Pull Request #397 · symfony/symfony-standard · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Nov 27, 2020. It is now read-only.

configure strict_requirements: null in production #397

Merged
merged 2 commits into from
Aug 30, 2012
Merged

configure strict_requirements: null in production #397

merged 2 commits into from
Aug 30, 2012

Conversation

Tobion
Copy link
Contributor
@Tobion Tobion commented Aug 30, 2012

possible since symfony/symfony#5187

# always pass the requirements. Otherwise it would break your link (or even site with
# strict_requirements = true). So we can disable the requirements check completely for
# enhanced performance with strict_requirements = null.
framework: router: strict_requirements: null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be:

framework:
    router:
        strict...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, if you think its more readable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's mostly because it's how we've done it everywhere (docs included).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Yeah for multiple options it makes sense. But for single ones, its probably easier in one line.

fabpot added a commit that referenced this pull request Aug 30, 2012
Commits
-------

ef43472 added upgrade note for strict_requirements = null
33eaa39 configure strict_requirements: null in production

Discussion
----------

configure strict_requirements: null in production

possible since symfony/symfony#5187
@fabpot fabpot merged commit ef43472 into symfony:master Aug 30, 2012
@Tobion
Copy link
Contributor Author
Tobion commented Sep 6, 2012

@fabpot as you reverted symfony/symfony#5187 for some reason, you need to revert this too.

@Tobion
Copy link
Contributor Author
Tobion commented Sep 8, 2012

@fabpot ping

fabpot added a commit that referenced this pull request Sep 8, 2012
This reverts commit 85e19a5, reversing
changes made to 22771ee.
@fabpot
Copy link
Member
fabpot commented Sep 8, 2012

reverted now.

fabpot added a commit that referenced this pull request Oct 14, 2012
* 2.1:
  You cannot start a Plain Style Scalar with an Indicator (%). Plain Style Scalars which have a leading % should be changed to double-quote style scalars.
  Correcting YAML Markup in app/config to be valid YAML 1.2o
  Update README.md
  updated VENDORS for 2.1.2
  finished reverting previous changes
  reverted unwanted changes
  updated deps
  Download Composer from a secure source
  added .travis.yml
  updated VENDORS for 2.1.1
  Revert "merged branch Tobion/patch-1 (PR #397)"
  fixed composer file
  Fixed an issue with installs from composer not working due to version conflict on symfony/symfony
  Add reference to PHP bug #62874 for 5.3.16 requirement
  Add more verbose warning for PHP 5.3.16
lsmith77 added a commit to liip-forks/symfony-standard that referenced this pull request Oct 15, 2012
# By Fabien Potencier (8) and others
# Via Fabien Potencier
* master:
  re-added travis file (missing due to a bad merge, refs symfony#432)
  You cannot start a Plain Style Scalar with an Indicator (%). Plain Style Scalars which have a leading % should be changed to double-quote style scalars.
  Correcting YAML Markup in app/config to be valid YAML 1.2o
  Update README.md
  updated VENDORS for 2.1.2
  finished reverting previous changes
  reverted unwanted changes
  updated deps
  Download Composer from a secure source
  added .travis.yml
  updated VENDORS for 2.1.1
  Revert "merged branch Tobion/patch-1 (PR symfony#397)"
  fixed composer file
  Fixed an issue with installs from composer not working due to version conflict on symfony/symfony
  Add reference to PHP bug #62874 for 5.3.16 requirement
  Add more verbose warning for PHP 5.3.16

Conflicts:
	.travis.yml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0