-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
configure strict_requirements: null in production #397
Conversation
# always pass the requirements. Otherwise it would break your link (or even site with | ||
# strict_requirements = true). So we can disable the requirements check completely for | ||
# enhanced performance with strict_requirements = null. | ||
framework: router: strict_requirements: null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be:
framework:
router:
strict...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, if you think its more readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's mostly because it's how we've done it everywhere (docs included).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Yeah for multiple options it makes sense. But for single ones, its probably easier in one line.
Commits ------- ef43472 added upgrade note for strict_requirements = null 33eaa39 configure strict_requirements: null in production Discussion ---------- configure strict_requirements: null in production possible since symfony/symfony#5187
@fabpot as you reverted symfony/symfony#5187 for some reason, you need to revert this too. |
@fabpot ping |
reverted now. |
* 2.1: You cannot start a Plain Style Scalar with an Indicator (%). Plain Style Scalars which have a leading % should be changed to double-quote style scalars. Correcting YAML Markup in app/config to be valid YAML 1.2o Update README.md updated VENDORS for 2.1.2 finished reverting previous changes reverted unwanted changes updated deps Download Composer from a secure source added .travis.yml updated VENDORS for 2.1.1 Revert "merged branch Tobion/patch-1 (PR #397)" fixed composer file Fixed an issue with installs from composer not working due to version conflict on symfony/symfony Add reference to PHP bug #62874 for 5.3.16 requirement Add more verbose warning for PHP 5.3.16
# By Fabien Potencier (8) and others # Via Fabien Potencier * master: re-added travis file (missing due to a bad merge, refs symfony#432) You cannot start a Plain Style Scalar with an Indicator (%). Plain Style Scalars which have a leading % should be changed to double-quote style scalars. Correcting YAML Markup in app/config to be valid YAML 1.2o Update README.md updated VENDORS for 2.1.2 finished reverting previous changes reverted unwanted changes updated deps Download Composer from a secure source added .travis.yml updated VENDORS for 2.1.1 Revert "merged branch Tobion/patch-1 (PR symfony#397)" fixed composer file Fixed an issue with installs from composer not working due to version conflict on symfony/symfony Add reference to PHP bug #62874 for 5.3.16 requirement Add more verbose warning for PHP 5.3.16 Conflicts: .travis.yml
possible since symfony/symfony#5187