[Twig] Fix Twig namespaces #9994
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
reviewed
Jul 2, 2018
templating/twig_extension.rst
Outdated
| ); | ||
| } | ||
| } | ||
|
|
||
| Then, create the new ``AppRuntime`` class (it's not required but these classes | ||
| are suffixed with ``Runtime`` by convention) and include the logic of the | ||
| are suffixed with ``Runtime`` by convention), implement the ``RuntimeExtensionInterface`` and include the logic of the |
There was a problem hiding this comment.
Please move this change in a dedicated PR targeting 3.4 and rebase the current on 2.8. Thanks!
f5a3dbc to
2ea73f6
Compare
2ea73f6 to
57d3ce1
Compare
|
@Phenix789 thanks for your first Symfony Docs contribution! We merged it in 2.8 and we'll merge in the other branches automatically. Thanks! |
javiereguiluz
added a commit
that referenced
this pull request
Jul 3, 2018
This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #9994). Discussion ---------- [Twig] Fix Twig namespaces <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Fix Twig namespaces used in documentation Commits ------- de8b1e7 Fix Twig namespaces and update doc for twig runtime extension
javiereguiluz
added a commit
that referenced
this pull request
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Twig namespaces used in documentation