[Process] document command-as-arrays#9988
Merged
xabbuh merged 1 commit intosymfony:3.4from Aug 4, 2018
Merged
Conversation
432973c to
d05bf61
Compare
d05bf61 to
9a74778
Compare
HeahDude
approved these changes
Jul 1, 2018
components/process.rst
Outdated
| command-line is parsed by the underlying shell of your operating system. This allows | ||
| using e.g. stream redirections or conditional execution, but this is a lot less portable | ||
| since each OS (esp. Windows vs Unix-like) deals with escaping and parsing differently. | ||
| When passing a command-line string, it becomes your responsibility to deal this. |
80aa41d to
f9a9eaa
Compare
OskarStark
approved these changes
Jul 1, 2018
Toflar
reviewed
Jul 2, 2018
components/process.rst
Outdated
| $process = new Process('echo %MESSAGE%'); | ||
|
|
||
| // On both Unix-like and Windows | ||
| $process->run(null, 'MESSAGE' => 'Something to output']); |
Contributor
There was a problem hiding this comment.
The command is missing or what did I miss?
Member
There was a problem hiding this comment.
The command is echo ... This line is the ->run() method call, which is the same for all OS. Only the command definition depends on the OS.
Contributor
There was a problem hiding this comment.
I see, when I read this part it feels like it wants to show me the difference between using a string or an array value which is not the case. That's a bit confusing.
Not sure you understand what I mean. So when I read On both Unix-like and Windows it sounds to me like the example should tell me how I could make the command run on both systems without dealing with escaping. Oh man, this is hard to explain 😄
Toflar
reviewed
Jul 2, 2018
components/process.rst
Outdated
| Symfony 3.3. | ||
|
|
||
| Defining commands as arrays of arguments is recommended because the Process | ||
| component escapes those arguments automatically. Defining commands as |
Contributor
There was a problem hiding this comment.
"Automatically escaping" does not seem to be the right wording according to your comment in symfony/symfony#27796 (comment) 😄
21b2bf2 to
7cff554
Compare
7cff554 to
b638c88
Compare
Member
|
Thank you @nicolas-grekas. |
xabbuh
added a commit
that referenced
this pull request
Aug 4, 2018
apfelbox
reviewed
Aug 5, 2018
|
|
||
| $process = new Process(array('/path/command', '--flag', 'arg 1', 'etc.')); | ||
|
|
||
| If you need use stream redirections, conditional execution, or any other |
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Aug 8, 2018
* 3.4: Simplified the "Release Process" page [Workflow] Fix typo documentation Fix mismatched list items [symfony#9988] fix minor typos [symfony#10099] update XML and PHP config examples [symfony#9969] fix a minor typo [symfony#10022] fix a minor typo preUpdate Event Listener On Uploaded Imagery [symfony#10124] fix XML attribute name [symfony#10062] fix the code block [PHPUnitBridge] Explain how to show stack traces Fix docs on trusted hosts opcode optimizations
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Aug 8, 2018
* 4.1: Simplified the "Release Process" page [Workflow] Fix typo documentation Fix mismatched list items typos in sample code [symfony#9988] fix minor typos [symfony#10099] update XML and PHP config examples [symfony#9969] fix a minor typo [symfony#10022] fix a minor typo preUpdate Event Listener On Uploaded Imagery [symfony#9757] fix rst syntax [symfony#10124] fix XML attribute name [symfony#10062] fix the code block [PHPUnitBridge] Explain how to show stack traces Fix docs on trusted hosts opcode optimizations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #9897