8000 Removed the full config dumps from config reference articles by javiereguiluz · Pull Request #9961 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Removed the full config dumps from conf 8000 ig reference articles #9961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Removed the full config dumps from config reference articles #9961

wants to merge 3 commits into from

Conversation

javiereguiluz
Copy link
Member

This was discussed in the internal Slack chat used by doc maintainers. We think this config dump is not really useful for readers and it complicates maintenance.

I also changed some page titles to make them more human and SEO friendly.

HeahDude
HeahDude approved these changes Jun 25, 2018
View reviewed changes
Copy link
Contributor
@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

reference/configuration/assetic.rst Outdated

.. code-block:: yaml
# displays the default config values defined by Symfony
$ php bin/console config:dump assetic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should write full command name: php bin/console config:dump-references assetic

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I've changed this. Thanks!

@javiereguiluz javiereguiluz mentioned this pull request Jul 3, 2018
Merged
javiereguiluz added a commit that referenced this pull request Jul 3, 2018
@javiereguiluz
minor #10005 Removed the full config dump of FrameworkBundle (javiere…
7bf9a0a 
…guiluz)

This PR was merged into the 2.8 branch.

Discussion
----------

Removed the full config dump of FrameworkBundle

In #9961 we removed all config dumps ... but I forgot to remove the config dump of FrameworkBundle.

Commits
-------

eaf187b Removed the full config dump of FrameworkBundle
@xabbuh xabbuh added this to the 2.8 milestone Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeahDude HeahDude HeahDude approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.
4 participants
@javiereguiluz @HeahDude @xabbuh @carsonbot
0