E676 Fix wrong place of parent constructor call by Nek- · Pull Request #9863 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Fix wrong place of parent constructor call #9863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix wrong place of parent constructor call #9863

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix wrong place of parent constructor call 
Calling parent constructor after doing stuff in the overrided
constructor is a bad habit.
  • Loading branch information
@Nek-
Nek- authored Jun 1, 2018
commit 7b3b9fce81ba99a1731066e5b94704b71062b985
4 changes: 2 additions & 2 deletions console.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,9 +246,9 @@ as a service, you can use normal dependency injection. Imagine you have a

public function __construct(UserManager $userManager)
{
$this->userManager = $userManager;

parent::__construct();

$this->userManager = $userManager;
}

// ...
Expand Down
0