8000 Added code block for custom loggers by artoroz · Pull Request #9849 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Added code block for custom loggers #9849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Added code block for custom loggers #9849

wants to merge 1 commit into from

Conversation

artoroz
Copy link
@artoroz artoroz commented May 29, 2018

No description provided.

@javiereguiluz javiereguiluz mentioned this pull request Jul 12, 2018
Merged
@javiereguiluz
Copy link
Member

Thanks for your contribution. Sadly, this was targeted at 2.7/2.8 branches ... where is not that hard to know how to inject the specific Monolog service. In 3.4 branch and others, it's more tricky, specially for those new to autowiring. That's why I'm closing this pull request in favor in this other one #10049.

I'm sorry that your first contribution to Symfony Docs didn't make it ... but I thank you because it made us realize how we could improve Symfony Docs. So I'm looking forward to your next contributions. Thanks!

javiereguiluz added a commit that referenced this pull request Jul 13, 2018
@javiereguiluz
minor #10049 Mention how to inject a specific Monolog service (javier…
ca35570 
…eguiluz)

This PR was merged into the 3.4 branch.

Discussion
----------

Mention how to inject a specific Monolog service

This replaces #9849 and links to the explanation about how to wire specific services in the container.

Commits
-------

391d3e0 Mention how to inject a specific Monolog service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artoroz @javiereguiluz @carsonbot
0