8000 Document the hidden services and update debug:container docs by javiereguiluz · Pull Request #9775 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Document the hidden services and update debug:container docs #9775

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Document the hidden services and update debug:container docs #9775

wants to merge 3 commits into from

Conversation

javiereguiluz
Copy link
Member

This fixes #9658.

@javiereguiluz javiereguiluz added this to the 4.1 milestone May 15, 2018
@javiereguiluz javiereguiluz changed the title Document the hidden services and update debug:cotnainer docs Document the hidden services and update debug:container docs May 16, 2018
ndench
ndench approved these changes May 18, 2018
View reviewed changes
Copy link
Contributor
@ndench ndench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Are hidden services definitely starting with a . and not having a hidden: true property?

xabbuh
xabbuh reviewed May 18, 2018
View reviewed changes
service_container/debug.rst Outdated
By default, only public services are shown, but you can also view private services:
Hidden services, those whose ID starts with a dot character (``.``) aren't
included by default in the output of this command. Add the ``--show-hidden``
option to list them too:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need the paragraph? In other examples, we use inline comments which IMO would fit here well too:

.. code-block:: terminal

    $ php bin/console debug:container

    # use the --show-hidden option to display hidden services (services whose ID starts with a dot)
    $ php bin/console debug:container --show-hidden

javiereguiluz added a commit that referenced this pull request May 18, 2018
@javiereguiluz
minor #9775 Document the hidden services and update debug:container d…
2cb5242 
…ocs (javiereguiluz)

This PR was squashed before being merged into the 4.1 branch (closes #9775).

Discussion
----------

Document the hidden services and update debug:container docs

This fixes #9658.

Commits
-------

8010808 Document the hidden services and update debug:container docs
@javiereguiluz javiereguiluz mentioned this pull request May 18, 2018
Closed
@javiereguiluz javiereguiluz deleted the fix_9658 branch May 24, 2018 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@ndench ndench ndench approved these changes

Assignees
No one assigned
Labels
DependencyInjection Status: Reviewed
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@javiereguiluz @xabbuh @ndench @carsonbot
0