Improved the Symfony License pages #9767
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
requested changes
May 14, 2018
contributing/code/license.rst
Outdated
| `Symfony licenses and trademarks`_. | ||
|
|
||
| .. `the MIT license`: https://en.wikipedia.org/wiki/MIT_License | ||
| .. _`license of the Symfony documentation`: https://symfony.com/doc/current/contributing/documentation/license.html |
There was a problem hiding this comment.
we should use the doc role for internal links instead
| .. _`CC BY-SA 3.0`: http://creativecommons.org/licenses/by-sa/3.0/ | ||
| .. _Legal Code (the full license): http://creativecommons.org/licenses/by-sa/3.0/legalcode | ||
| .. _`license of the Symfony code`: https://symfony.com/doc/current/contributing/code/license.html |
xabbuh
reviewed
May 14, 2018
contributing/code/license.rst
Outdated
| Check out the :doc:`license of the Symfony documentation </contributing/documentation/license>` | ||
| and other `Symfony licenses and trademarks`_. | ||
|
|
||
| .. `the MIT license`: https://en.wikipedia.org/wiki/MIT_License |
There was a problem hiding this comment.
missing underscore:
.. _`the MIT license`: https://en.wikipedia.org/wiki/MIT_License
xabbuh
approved these changes
May 14, 2018
javiereguiluz
added a commit
that referenced
this pull request
May 14, 2018
This PR was squashed before being merged into the 2.7 branch (closes #9767). Discussion ---------- Improved the Symfony License pages We need to be more precise because "Symfony License" !== "Symfony Code License". When you Google for Symfony License, the first result should be the actual second result:  Commits ------- acc3909 Improved the Symfony License pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be more precise because "Symfony License" !== "Symfony Code License". When you Google for Symfony License, the first result should be the actual second result: