[ExpressionLanguage] Add missing argument in example code #9764
Conversation
|
It's hard for me to review this because there are no many examples of protected function registerFunctions()
{
$this->register('constant', function ($constant) {
return sprintf('constant(%s)', $constant);
}, function (array $values, $constant) {
return constant($constant);
});
}As you can see, the first anonymous function passed to |
|
@javiereguiluz All If we look at one such example: new ExpressionFunction('is_granted', function ($attributes, $object = 'null') {
return sprintf('$auth_checker->isGranted(%s, %s)', $attributes, $object);
}, function (array $variables, $attributes, $object = null) {
return $variables['auth_checker']->isGranted($attributes, $object);
}),It is clear that the compiler doesn't get the arguments. It has to reference these as normal PHP variables. This is also logical, as the compiler transforms an expression to PHP code and this PHP code will be run later on with some variables (Arguments). These arguments are not yet known when the compiler function is run, so the arguments cannot be provided as argument to the compiler function. So instead of update the code, can you please update the incorrect description below? Thanks for finding & trying to fix bugs in the Symfony docs! |
|
We finally made the changes requested by Wouter, so we can merge here. Thanks! |
… (kevin-verschaeve, javiereguiluz) This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #9764). Discussion ---------- [ExpressionLanguage] Add missing argument in example code Like the docs says just below > Both the compiler and evaluator are passed an arguments variable as their first argument The example was missing the `$arguments` for the `compiler` method Commits ------- 280c23c Reword 3ce4089 [ExpressionLanguage] Add missing argument in example code
|
Thanks Javier :) |
Like the docs says just below
The example was missing the
$argumentsfor thecompilermethod