8000 Be consistent how we write "core team" by Nyholm · Pull Request #9622 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content
Dismiss alert

Be consistent how we write "core team" #9622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2018

Conversation

Nyholm
Copy link
Member
@Nyholm Nyholm commented Apr 19, 2018

While writing another PR, I discovered that we are not consistent how we refer to the Symfony core team.

We are currently using "core team", "Core team", "Core Team" and "core-team". This PR make sure that we are always using "core team". That term was the most popular one.

Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one file untouched that has the same situation: But unsure if this should be changed.

@Nyholm
Copy link
Member Author
Nyholm commented Apr 19, 2018

Thank you for the review. That one is special. All those links are capitalized.

@xabbuh xabbuh added this to the 2.7 milestone Apr 19, 2018
@javiereguiluz javiereguiluz changed the base branch from master to 2.7 April 19, 2018 09:48
@javiereguiluz
Copy link
Member

Thanks Tobias.

@javiereguiluz javiereguiluz merged commit 4473a23 into symfony:2.7 Apr 19, 2018
javiereguiluz added a commit that referenced this pull request Apr 19, 2018
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #9622).

Discussion
----------

Be consistent how we write "core team"

While writing another PR, I discovered that we are not consistent how we refer to the Symfony core team.

We are currently using "core team", "Core team", "Core Team" and "core-team". This PR make sure that we are always using "core team". That term was the most popular one.

Commits
-------

4473a23 Be consistent how we write "core team"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants
0