8000 Use "children" property instead of "child" by liviubalan · Pull Request #9610 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

Use "children" property instead of "child" #9610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

liviubalan
Copy link
Contributor

Fix error: Neither the property "child" nor one of the methods "child()", "getchild()"/"ischild()"/"haschild()" or "__call()" exist and have public access in class "Symfony\Component\Form\FormView".

Fix error: Neither the property "child" nor one of the methods "child()", "getchild()"/"ischild()"/"haschild()" or "__call()" exist and have public access in class "Symfony\Component\Form\FormView".
@javiereguiluz javiereguiluz changed the base branch from 3.4 to 2.7 April 17, 2018 07:07
@javiereguiluz
Copy link
Member

Good catch! We merged it on 2.7 branch, which is the oldest maintained branch that contains the error. Thanks!

@javiereguiluz javiereguiluz merged commit 26349df into symfony:2.7 Apr 17, 2018
javiereguiluz added a commit that referenced this pull request Apr 17, 2018
This PR was submitted for the 3.4 branch but it was merged into the 2.7 branch instead (closes #9610).

Discussion
----------

Use "children" property instead of "child"

Fix error: Neither the property "child" nor one of the methods "child()", "getchild()"/"ischild()"/"haschild()" or "__call()" exist and have public access in class "Symfony\Component\Form\FormView".

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

26349df Use "children" property instead of "child"
@@ -337,7 +337,7 @@ You can also apply a form theme to a specific child of your form:

.. code-block:: html+twig

{% form_theme form.child 'form/fields.html.twig' %}
{% form_theme form.children 'form/fields.html.twig' %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the previous example was right in that it assumed that you would replace child with the name of the actual child form. Can we make that more clear with another example?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #9635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0