8000 Update custom_authentication_provider.rst by lucchese-pd · Pull Request #9502 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Update custom_authentication_provider.rst #9502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2018
Merged

Update custom_authentication_provider.rst #9502

merged 1 commit into from
Apr 16, 2018

Conversation

lucchese-pd
Copy link
Contributor

No description provided.

javiereguiluz
javiereguiluz approved these changes Mar 27, 2018
View reviewed changes
Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this because the regex is a bit complicated. But before merging, let's wait to read other opinions from other doc mergers. Thanks!

@javiereguiluz javiereguiluz added this to the 2.7 milestone Apr 16, 2018
@javiereguiluz javiereguiluz changed the base branch from 2.8 to 2.7 April 16, 2018 08:16
@javiereguiluz
Copy link
Member
javiereguiluz commented Apr 16, 2018 •
edited
Loading

Thank you @lucchese-pd and congrats on your first Symfony Docs contribution. By the way, we merged this on the 2.7 branch.

@javiereguiluz javiereguiluz merged commit 70452ae into symfony:2.7 Apr 16, 2018
javiereguiluz added a commit that referenced this pull request Apr 16, 2018
@javiereguiluz
minor #9502 Update custom_authentication_provider.rst (lucchese-pd)
f36e023 
This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #9502).

Discussion
----------

Update custom_authentication_provider.rst

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

70452ae Update custom_authentication_provider.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@lucchese-pd @javiereguiluz @carsonbot
0