Added Michael to the Core Team group #9498
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we need a new team for Security related issues. |
|
Thanks @javiereguiluz. |
OskarStark
approved these changes
Mar 28, 2018
fabpot
reviewed
Mar 28, 2018
contributing/code/core_team.rst
Outdated
|
|
||
| * Decide to merge or reject a pull request. | ||
|
|
||
| 4. **Security Team** | ||
|
|
||
| * Decide to merge or reject a pull request related to security issues. |
There was a problem hiding this comment.
I think the security team is orthogonal to the other ones. Michael could be also a merger for some components for instance. It's also more than deciding things. It's about managing the security process from reporting to releasing.
fabpot
approved these changes
Mar 28, 2018
javiereguiluz
added a commit
that referenced
this pull request
Mar 28, 2018
This PR was squashed before being merged into the 2.7 branch (closes #9498). Discussion ---------- Added Michael to the Core Team group It was announced here: https://symfony.com/blog/new-core-team-member-security-team-leader but we didn't add him because it's not a merger but the leader of the Security Team ... so I didn't know where to include him. @fabpot do you agree to add him to "deciders" too ... or do you prefer to create a new group called "Security Team"? Thanks! Commits ------- a372ebc Added Michael to the Core Team group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was announced here: https://symfony.com/blog/new-core-team-member-security-team-leader but we didn't add him because it's not a merger but the leader of the Security Team ... so I didn't know where to include him.
@fabpot do you agree to add him to "deciders" too ... or do you prefer to create a new group called "Security Team"? Thanks!