Adding MigratingSessionHandler docs #9496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Apr 6, 2018
…ssmotley) This PR was squashed before being merged into the 4.1-dev branch (closes #26096). Discussion ---------- [HttpFoundation] Added a migrating session handler | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#9496 - [x] gather feedback for my changes - [x] submit changes to the documentation - [x] update the changelog When migrating to a new session handler on a live system, it's useful to be able to do it with no loss of session data. This migrating handler allows the sessions to be written to an additional handler to enable a migration workflow like: * Switch to migrating handler, with your new handler as the 'write only' one. The old handler behaves as usual and sessions get written to the new one. * After verifying the data in the new handler (and after the session gc period), switch the migrating handler to use your old handler as the 'write only' one instead, so the sessions will now be read from the new handler. This step allows easier rollbacks. * After verifying everything, switch from the migrating handler to the new handler Commits ------- 3acd548 [HttpFoundation] Added a migrating session handler
linaori
suggested changes
May 17, 2018
| * Switch to the migrating handler, with your new handler as the write-only one. The old handler behaves as usual and sessions get written to the new one. | ||
| * After your session gc period, verify the data in the new handler | ||
| * Update the migrating handler to use the old handler as the write-only one, so the sessions will now be read from the new handler. This step allows easier rollbacks. | ||
| * After verifying everything, switch from the migrating handler to the new handler |
There was a problem hiding this comment.
Missing a full stop at the end
* After verifying everything, switch from the migrating handler to the new handler.
There was a problem hiding this comment.
I have added that and tweaked the text a little bit.
Added full-stop and tweaked text.
Added missing "that".
linaori
approved these changes
May 17, 2018
ndench
approved these changes
May 18, 2018
|
Would it make sense to move the detailed description to a new guide and only link to it from this page? |
|
@xabbuh it looks like the page is becoming quite big already with this addition, it might be an option |
javiereguiluz
approved these changes
May 22, 2018
|
Thanks @rossmotley. This was a really nice first contribution to Symfony Docs! Thank you. |
javiereguiluz
added a commit
that referenced
this pull request
May 24, 2018
…uiluz) This PR was merged into the 4.1 branch. Discussion ---------- Adding MigratingSessionHandler docs Adding `MigratingSessionHandler` documentation for symfony/symfony#26096 Commits ------- e93756f Added the versionadded directive 386f639 Reworded and simplified 7c8264d Update session_configuration.rst e971074 Update session_configuration.rst 91aa58d Adding MigratingSessionHandler docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
MigratingSessionHandlerdocumentation for symfony/symfony#26096