8000 Minor updates to entity_provider.rst by dunglas · Pull Request #9256 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Minor updates to entity_provider.rst #9256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Minor updates to entity_provider.rst #9256

wants to merge 1 commit into from

Conversation

dunglas
Copy link
Member
@dunglas dunglas commented Feb 13, 2018

No description provided.

@javiereguiluz javiereguiluz mentioned this pull request Feb 15, 2018
Merged
@javiereguiluz
Copy link
Member

Thanks for this Kévin. Sadly I must close in favor of #9269 because we should mention argon2i starting from 3.4 branch and we don't make changes like the one you proposed to initialize properties (in the docs we always initialize vars in constructors). Thanks!

javiereguiluz added a commit that referenced this pull request Feb 15, 2018
@javiereguiluz
minor #9269 Mention that argon2i doesn't need a salt either (javiereg…
9ac45bd 
…uiluz)

This PR was merged into the 3.4 branch.

Discussion
----------

Mention that argon2i doesn't need a salt either

Alternative solution to #9256.

Commits
-------

35d9936 Mention that argon2i doesn't need a salt either
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dunglas @javiereguiluz @carsonbot
0