8000 Update patches page by Burgov · Pull Request #916 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

Update patches page #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 16, 2011
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updates per @stof
  • Loading branch information
Burgov committed Dec 15, 2011
commit 77ffd39769bde007666e2e458c07c55eb2de53d9
15 changes: 8 additions & 7 deletions contributing/code/patches.rst
Original file line number Diff line number Diff line change
Expand Up @@ -96,21 +96,22 @@ Set up your user information with your real name and a working email address:
.. tip::

Windows users: when installing Git, the installer will ask what to do with
line endings and suggests to replace all Lf by CrLf. This is the wrong
setting if you wish to contribute to Symfony! Either select the as-is method
or the Lf method. If you have already installed Git, you can check the value
of this setting by typing:
line endings and suggests to replace all Lf by CRLF. This is the wrong
setting if you wish to contribute to Symfony! Selecting the as-is method is
your best choice, as git will convert your line feeds to the ones in the
repository. If you have already installed Git, you can check the value of
this setting by typing:

.. code-block:: bash

$ git config core.autocrlf
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it actually possible to put code blocks in tips?


This will return either "false", "input" or "true", "true" being the wrong
value. Set it to another value by typing:
This will return either "false", "input" or "true", "true" and "false" being
the wrong values. Set it to another value by typing:

.. code-block:: bash

$ git config --global core.autocrlf false
$ git config --global core.autocrlf input

Replace --global by --local if you want to set it only for the active
repository
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the recommended value is input to avoid committing files using CRLF (the Symfony CS require using LF as line endings). By putting it to false, you need to check manually if your new files are using LF as git won't convert it for you

Expand Down
0