8000 Removing very complex authentication article by weaverryan · Pull Request #8943 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content
8000

Removing very complex authentication article #8943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Removing very complex authentication article #8943

wants to merge 1 commit into from

Conversation

weaverryan
Copy link
Member

Hi guys!

I don't think we should document the most complex way to do authentication at all. There are almost NOT users that should do this, and those advanced users (basically, bundle authors?) can look at core code.

I also think we should update custom_password_authenticator.rst and api_key_authentication.rst to use Guard instead of SimpleAuth.

I've done this on 4.0 on purpose: I want to make these big changes on the current branch only.

javiereguiluz
javiereguiluz reviewed Dec 31, 2017
View reviewed changes
security/custom_authentication_provider.rst
@@ -4,655 +4,14 @@
How to Create a custom Authentication Provider
==============================================

.. tip::
Creating a custom authentication system is hard, and this entry will walk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this, but I'd like to improve the introduction of this article. This is not enough for me --> "Creating a custom authentication system is hard..." I'd like to know (very briefly!!) which is exactly a "custom authentication system" and in which edge cases should I consider it. In other words: what am I trying to do that Symfony can't provide it for me. Thanks!

@javiereguiluz javiereguiluz mentioned this pull request Jan 2, 2018
Closed
@sergiu-popa
Copy link

I followed the article to implement this authentication between Symfony and Android/iOS apps. If the article is removed... shouldn't we add one simpler instead? Something with JWT or another solution...

@Xymanek
Copy link
Xymanek commented Jan 26, 2018

👎 from me.

and those advanced users (basically, bundle authors?) can look at core code

Being an "advanced user" I must say that I spend way too much time trying to dissect sf's code. However I agree that such stuff should be clearly indicated as inappropriate for beginners/simple use cases.

Maybe "tag" them with something like [INTERNALS] in title. And add a big warning at the start:

This article is about Symfony's internal workings. Unless you are extending framework, building a bundle or contributing to Symfony itself you should not need information listed here.

And then link the guard article (in this case)

@javiereguiluz
Copy link
Member

Closing in favor of #10423, which overhauls the whole security docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@weaverryan @sergiu-popa @Xymanek @javiereguiluz @carsonbot
0