Flex node for Apache #8806
Flex node for Apache #8806
Conversation
|
I'm against the following question, but it might be useful to add a tip adding the file yourself with the content of |
setup/web_server_configuration.rst
Outdated
|
|
||
| $ cd my-project/ | ||
| $ composer require symfony/apache-pack | ||
|
|
There was a problem hiding this comment.
One way or another, the user will need the rewrite rules. They can either put them in public/.htaccess or put them in their virtual host. So:
- Let's rename this section to something like "Adding Rewrite Rules"
- Change the text from "recommended way" to "the easiest way".
- We should also say (in the text) what this does: it will install a
public/.htaccessfile - No need to show the
cd my-project
Then, after the command, mention that you can get a performance boost by putting the rewrite rules in your VirtualHost and changing AllowOverride All to AllowOverride None
|
Thanks @weaverryan for the feedback (I am sorry that sometimes I send bad English phrases but fortunately there are reviews! 🤓). Changes are in d71d22a. Ready for re-review. |
setup/web_server_configuration.rst
Outdated
|
|
||
| .. tip:: | ||
|
|
||
| A performance improvement can be achieved by putting the rewrite rules in your |
There was a problem hiding this comment.
Suggestion:
"by moving the rewrite rules from the .htaccess file to the VirtualHost block of your Apache configuration and disallowing .htaccess overrides by changing AllowOverride All to AllowOverride None (where though?).
setup/web_server_configuration.rst
Outdated
|
|
||
| $ composer require symfony/apache-pack | ||
|
|
||
| This recipe will install the ``.htaccess`` file in the ``public/`` directory. |
There was a problem hiding this comment.
"the .htaccess file" => "a .htaccess files containing the rewrite rules"?
|
Thank you Ricardo for taking this on! |
This PR was submitted for the master branch but it was merged into the 4.0 branch instead (closes #8806). Discussion ---------- Flex node for Apache This is related to #8724. Commits ------- 23c49fa Minor changes 5f9b813 Update article block from pull request feedback. 0bee9a9 Forgot a apostrophe. 4f20edf Improvements on the apache section. 17748d3 Added the Flex node for Apache.
* 4.0: doc(http_foundation.rst): Fix code error which used create() instead of constructor method. [#8806] minor reword Minor changes Update article block from pull request feedback. Forgot a apostrophe. Improvements on the apache section. Added the Flex node for Apache. add back the trailing comma remove "choices_as_values" mention Fixed configuration block rendering in routing docs Update entity.rst Removing more AppBundle Follow the same code style in docblock annotations
This is related to #8724.