[FIX] Realpath improvement in PHP 7.2 #8753
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As PHP 7.2 provide a default value of 4096k (as seen https://github.com/php/php-src/blob/php-7.2.0RC6/UPGRADING#L357), the line about this improvement can be deleted.
|
Hmm, I don't think we can remove it completely: most users (at least for awhile) won't be using PHP 7.2. So, we should probably use the old text, but with some caveat that no change is needed on PHP 7.2. @Guikingone wdyt? |
|
@weaverryan Yes, good idea, I'm gonna update the file with a small block with the information. |
Added the tip block for PHP 7.2.
|
@weaverryan I've added a tip block for the PHP 7.2 improvement. |
OskarStark
reviewed
Dec 1, 2017
performance.rst
Outdated
|
|
||
| .. tip:: | ||
|
|
||
| Since PHP 7.2, the default value for ``realpath_cache_size``has been set to 4096K, feel free to delete this trick in your ``php.ini`` file. |
There was a problem hiding this comment.
space before has missing
|
@OskarStark Corrected :) |
|
Thanks @Guikingone! |
weaverryan
added a commit
that referenced
this pull request
Dec 1, 2017
…ryan) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #8753). Discussion ---------- [FIX] Realpath improvement in PHP 7.2 As PHP 7.2 provide a default value of 4096k (as seen https://github.com/php/php-src/blob/php-7.2.0RC6/UPGRADING#L357), the line about this improvement can be deleted. Commits ------- f10c7b3 tweaking language a519d8e fix(syntax): added a space before has 17a0b8a fix(tip): Add the tip block for realpth_cache_size e177ca9 [FIX](Realpath)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As PHP 7.2 provide a default value of 4096k (as seen https://github.com/php/php-src/blob/php-7.2.0RC6/UPGRADING#L357), the line about this improvement can be deleted.