Update Custom UsernamePasswordToken Authenticator #8743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, the "CustomUserMessageAuthenticationException" require a third parameter called $messageData ($messageData Data to be passed into the translator) that must be an array. Thanks for reviewing this modification.
javiereguiluz
approved these changes
Nov 25, 2017
There was a problem hiding this comment.
@mtazi9 nice catch! Thanks for fixing this and congrats on your first contribution to Symfony Docs!
|
@javiereguiluz thank you very much ! |
|
Very good catch. Thank you so much Mehdi! |
weaverryan
added a commit
that referenced
this pull request
Nov 27, 2017
This PR was merged into the 3.3 branch. Discussion ---------- Update Custom UsernamePasswordToken Authenticator Hello, the "CustomUserMessageAuthenticationException" require a third parameter called $messageData ($messageData Data to be passed into the translator) that must be an array. Thanks for reviewing this modification. Commits ------- 9cce028 Update Custom UsernamePasswordToken Authenticator
|
thank you @weaverryan, with pleasure :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
the "CustomUserMessageAuthenticationException" require a third parameter called $messageData ($messageData Data to be passed into the translator) that must be an array.
Thanks for reviewing this modification.