8000 Change service override docs by weaverryan · Pull Request #8728 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Change service override docs #8728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 24, 2017
Merged

Change service override docs #8728

merged 2 commits into from
Nov 24, 2017

Conversation

weaverryan
Copy link
Member

Updated to use Flex namespaces & directories. Also, since the kernel is a compiler pass... I think you can just put this all in the Kernel, right?

@weaverryan weaverryan added this to the 4.0 milestone Nov 21, 2017
xabbuh
xabbuh reviewed Nov 22, 2017
View reviewed changes
bundles/override.rst Outdated
use Symfony\Component\DependencyInjection\ContainerBuilder;

class OverrideServiceCompilerPass implements CompilerPassInterface
class Kernel extends BaseKernel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the use statement is missing

@weaverryan weaverryan merged commit 09fb4b1 into symfony:4.0 Nov 24, 2017
weaverryan added a commit that referenced this pull request Nov 24, 2017
@weaverryan
minor #8728 Change service override docs (weaverryan)
3e00ed1 
This PR was squashed before being merged into the 4.0 branch (closes #8728).

Discussion
----------

Change service override docs

Updated to use Flex namespaces & directories. Also, since the kernel is a compiler pass... I think you can just put this all in the Kernel, right?

Commits
-------

09fb4b1 Clarifying that our code is just additions
da666af Change service override docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh left review comments

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@weaverryan @xabbuh @carsonbot
0