Updated the Workflow articles to Symfony 4 #8654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
symfony/recipes#256 has been merged |
xabbuh
reviewed
Nov 15, 2017
workflow/state-machines.rst
Outdated
|
|
||
| public function __constructor(Registry $workflows) | ||
| { | ||
| $this->stateMachine = $workflows->get('pull_request'); |
There was a problem hiding this comment.
I would not do that inside the constructor. You'll never know when your service is initialized and if the registry is ready at this point which could lead to undesired side effects.
xabbuh
reviewed
Nov 15, 2017
workflow/usage.rst
Outdated
| { | ||
| public function edit(Registry $workflows) | ||
| { | ||
| $post = new \App\Entity\BlogPost(); |
There was a problem hiding this comment.
I would add a use statement for the class instead of using the FQCN here.
xabbuh
reviewed
Nov 15, 2017
workflow/usage.rst
Outdated
| // ... | ||
| } | ||
|
|
||
| // See all the available transition for the post in the current state |
xabbuh
reviewed
Nov 15, 2017
workflow/usage.rst
Outdated
| @@ -250,7 +272,8 @@ order: | |||
| * ``workflow.[workflow name].announce`` | |||
| * ``workflow.[workflow name].announce.[transition name]`` | |||
|
|
|||
| Here is an example how to enable logging for every time a the "blog_publishing" workflow leaves a place:: | |||
| Here is an example how to enable logging for every time the ``blog_publishing`` | |||
xabbuh
approved these changes
Nov 15, 2017
weaverryan
approved these changes
Nov 16, 2017
weaverryan
added a commit
that referenced
this pull request
Nov 16, 2017
…, weaverryan) This PR was merged into the master branch. Discussion ---------- Updated the Workflow articles to Symfony 4 The new file config paths are pending of this: symfony/recipes#256 Commits ------- 70dda7c adding use f9bb412 minor tweaks 8c540ce Removed an unneeded comment (Flex now includes Console by default) 5088d0e Lots of fixes 0261149 Fixed a typo 9690dfd Updated the Workflow articles to Symfony 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new file config paths are pending of this: symfony/recipes#256