8000 [FrameworkBundle] add documentation request context in Asset for use … by Warxcell · Pull Request #8653 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] add documentation request context in Asset for use … #8653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2018
Merged

[FrameworkBundle] add documentation request context in Asset for use … #8653

merged 2 commits into from
May 22, 2018

Conversation

Warxcell
Copy link
@Warxcell Warxcell commented Nov 14, 2017 •
edited
Loading

Add Asset Request Context in documentation for generating urls in console.

@Warxcell
Copy link
Author

Unfortunately I don't see anyway to change it per command basis. https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Asset/Context/RequestStackContext.php

@javiereguiluz javiereguiluz added this to the 3.4 milestone May 22, 2018
@javiereguiluz
Copy link
Member
javiereguiluz commented May 22, 2018 •
edited
Loading

Thanks for documenting this missing feature ... and congrats on your first Symfony Docs contribution!

@javiereguiluz javiereguiluz merged commit e8d16d1 into symfony:3.4 May 22, 2018
javiereguiluz added a commit that referenced this pull request May 22, 2018
@javiereguiluz
minor #8653 [FrameworkBundle] add documentation request context in As…
6dfd966 
…set for use … (Bozhidar Hristov, javiereguiluz)

This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] add documentation request context in Asset for use …

Add Asset Request Context in documentation for generating urls in console.

Commits
-------

e8d16d1 Some rewording
562832a [FrameworkBundle] add documentation request context in Asset for use in console commands
@javiereguiluz javiereguiluz mentioned this pull request May 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndench ndench ndench approved these changes

Assignees
No one assigned
Labels
FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Warxcell @javiereguiluz @ndench @carsonbot
0