Add new translations config path #8634
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
1 task
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Nov 23, 2017
… default paths (yceruto) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Update translation commands to work with default paths | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25062 | License | MIT | Doc PR | symfony/symfony-docs#8634 This should make translation commands (debug & update) work with `translator.default_path` and `twig.default_path` directories (introduced here in 3.4) and their overridden paths if available. Would be great to include also the custom paths mapping by the user, either `translator.paths` as `twig.paths`, but I'm not sure about the right way and probably it should be implemented on another branch. TODO - [x] Add some tests. Commits ------- dc72866 Update translation commands to work with default paths
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Nov 23, 2017
… default paths (yceruto) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Update translation commands to work with default paths | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#25062 | License | MIT | Doc PR | symfony/symfony-docs#8634 This should make translation commands (debug & update) work with `translator.default_path` and `twig.default_path` directories (introduced here in 3.4) and their overridden paths if available. Would be great to include also the custom paths mapping by the user, either `translator.paths` as `twig.paths`, but I'm not sure about the right way and probably it should be implemented on another branch. TODO - [x] Add some tests. Commits ------- dc7286625b Update translation commands to work with default paths
|
Now that symfony/symfony#25065 was merged, this PR is open to review! |
48f89a0 to
a227186
Compare
|
Closing in favor of #8733 which look much better that this one :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See symfony/symfony#24860 and symfony/symfony#25065