Update the multiple user providers article #8612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
approved these changes
Nov 10, 2017
xabbuh
approved these changes
Nov 10, 2017
|
Thanks Javier. |
wouterj
added a commit
that referenced
this pull request
Nov 12, 2017
This PR was merged into the master branch. Discussion ---------- Update the multiple user providers article In Symfony 4.0 we can finally remove any reference to: *"if you don't define a provider, the first one will be used"*. Commits ------- 7fdde84 Update the multiple user providers article
weaverryan
added a commit
that referenced
this pull request
Nov 12, 2017
… weaverryan) This PR was merged into the master branch. Discussion ---------- Removed deprecated features and notices @xabbuh and @weaverryan to avoid a nightmare or rebases and problems, could we please give top priority to merging this PR? Thanks! It doesn't have to be perfect or 100% completed. We can do more fixes in another PR. Thanks! ----- Some articles explain things that are removed. Instead of removing those articles entirely and to avoid user confusion, I propose to keep those articles but explain that those features no longer exist. For example, `security/acl.rst` now contains the following: ```rst .. index:: single: Security; Access Control Lists (ACLs) How to Use Access Control Lists (ACLs) ====================================== .. caution:: ACL support was removed in Symfony 4.0. Install the `Symfony ACL bundle`_ and refer to its documentation if you want to keep using ACL. .. _`Symfony ACL bundle`: https://github.com/symfony/acl-bundle ``` Articles like this one: * security/acl.rst * security/acl_advanced.rst * components/event_dispatcher/container_aware_dispatcher.rst We can remove all these deprecated articles in 4.1 ----- @iltar could you please create a PR to update the changes related to "controller arguments" in these two articles? Thanks! * `components/http_kernel.rst` * `create_framework/http_kernel_controller_resolver.rst` I don't understand the changes well (`ControllerResolverInterface` removed `getArguments()`) ----- @HeahDude could you please create a PR to update the changes needed about the deprecation of using `false` in `property_path` instead of `mapped` in `reference/forms/types/options/property_path.rst.inc`? Thanks! ----- There is a pending deprecation message in `security/multiple_user_providers.rst` ... but that's fixed in the pending PR #8612. ----- A final question: I've removed the explanation of the deprecated `kernel.root_dir` in `reference/configuration/kernel.rst` and kept only `kernel.project_dir`. Would you instead prefer to keep a reference to the still heavily used `kernel.root_dir` to explain that it's deprecated? Commits ------- 02c676a fixing old reference eb53f14 Fixing test failure 47a224a Fixed ater Wouter's review 597b75b Removed more references about profiler.matcher option 0266046 Removed deprecated features and notices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Symfony 4.0 we can finally remove any reference to: "if you don't define a provider, the first one will be used".