Adding warning about non-service arguments for controllers #8558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Oct 29, 2017
weaverryan
added a commit
that referenced
this pull request
Oct 29, 2017
…ers (weaverryan) This PR was merged into the 3.3 branch. Discussion ---------- Adding warning about non-service arguments for controllers Hi guys! See: symfony/symfony#24555 (comment) This is for 3.3. In 3.4 we can improve this further: by updating the example of this to use `bind` (which is much nicer than the ugly tag) and probably show an example of using `bind` along with a scalar argument to the constructor. In other words, 3.4 is a todo once this is merged. Thanks! Commits ------- 72a0685 Adding warning about non-service arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
See: symfony/symfony#24555 (comment)
This is for 3.3. In 3.4 we can improve this further: by updating the example of this to use
bind(which is much nicer than the ugly tag) and probably show an example of usingbindalong with a scalar argument to the constructor. In other words, 3.4 is a todo once this is merged.Thanks!