[Console] Command lazy loading #8502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
811772e to
a9445e4
Compare
yceruto
reviewed
Oct 10, 2017
console/lazy_commands.rst
Outdated
| $application->setCommandLoader($commandLoader); | ||
| $application->run(); | ||
|
|
||
| This way, the ``HeavyCommand`` instance will be created only when the ``app:foo`` |
console/lazy_commands.rst
Outdated
| 'app:foo' => FooCommand::class, | ||
| )); | ||
|
|
||
| Like this, executing the `app:foo` command will load the ``FooCommand`` service |
There was a problem hiding this comment.
double `` around of app:foo ?
a9445e4 to
0ca3935
Compare
|
@yceruto comments addressed, thanks! |
0ca3935 to
4267622
Compare
xabbuh
reviewed
Oct 13, 2017
console/commands_as_services.rst
Outdated
|
|
||
| .. configuration-block:: | ||
|
|
||
| .. code-block:: yaml |
4267622 to
96461f8
Compare
xabbuh
approved these changes
Oct 13, 2017
ogizanagi
approved these changes
Oct 13, 2017
javiereguiluz
approved these changes
Oct 13, 2017
|
@chalasr thanks for providing this feature and for documenting it. In a minor reword commit, I made this change: -register an intermediate router ...
+register an intermediate loader ...Please confirm that it's correct to use "loader" instead of "router". Thanks! |
|
@javiereguiluz Absolutely correct, thank you for that and your other fixes. |
weaverryan
added a commit
that referenced
this pull request
Oct 29, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [Console] Command lazy loading Fixes #8147. Any help regarding wording/formatting would be much appreciated as usual :) Commits ------- e2d445e Minor rewords a6aac8f Break long lines and add blank lines after RST directives 96461f8 Command lazy loading
weaverryan
added a commit
that referenced
this pull request
Oct 29, 2017
|
Thanks @chalasr! Really great feature and accomplishment - congrats :) |
weaverryan
added a commit
that referenced
this pull request
Oct 29, 2017
* 3.4: (81 commits) Fixed a RST syntax issue Mention that ACL is deprecated in the security config reference Update questionhelper.rst Remove TableHelper Page [#8416] Minor tweaks Minor tweaks to #8502 Documented the new config prototype shortcuts Document the new RequestExceptionInterface Docs re-org and removal of small sections Processed xabbuh comments Fixes Fixed a grammar issue remove deprecated feature description Fix a small typo error (number.rst) Remove deprecated proxy argument Fix instance of class in express language in DI Missing use reference Unused Private param in documentation Doctrine event listener could persist a null value Added about command in debug page ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8147.
Any help regarding wording/formatting would be much appreciated as usual :)