Updated Guard article for the GuardAuthenticatorInterface deprecation #8497
8000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Oct 9, 2017
security/guard_authentication.rst
Outdated
| .. versionadded:: 3.4 | ||
| The ``supports()`` method was introduced in Symfony 3.4. In previous Symfony | ||
| versions, the authenticator could be skipped returning ``null`` in the | ||
| ``getCredentials()`` method. |
There was a problem hiding this comment.
These lines should be indented to be part of the definition item.
xabbuh
approved these changes
Oct 10, 2017
chalasr
approved these changes
Oct 10, 2017
| **getCredentials(Request $request)** | ||
| This will be called on *every* request and your job is to read the token (or | ||
| whatever your "authentication" information is) from the request and return it. | ||
| If you return ``null``, the rest of the authentication process is skipped. Otherwise, | ||
| ``getUser()`` will be called and the return value is passed as the first argument. | ||
| These credentials are later passed as the first argument ot ``getUser()``. |
|
Thank you Javier. |
xabbuh
added a commit
that referenced
this pull request
Oct 13, 2017
… deprecation (javiereguiluz) This PR was squashed before being merged into the 3.4 branch (closes #8497). Discussion ---------- Updated Guard article for the GuardAuthenticatorInterface deprecation This fixes #8485. Commits ------- e889c94 Updated Guard article for the GuardAuthenticatorInterface deprecation
xabbuh
added a commit
that referenced
this pull request
Oct 27, 2017
* 3.4: (27 commits) [#8549] update ordered list syntax Minor tweaks Add default_path option reference [Form] Add debug:form command to debug page Added option to disable type enforcement in serializer Explained the possibility of defining custom deprecation messages [config] Add a note about deprecated a node [#8471] minor reword Explained the DomCrawler charset guessing mechanism Added a bundle deprecation notice in other articles [#8497] fix typo Updated Guard article for the GuardAuthenticatorInterface deprecation Deprecate auto picking the first provider Explain the new ColorType a bit more Explain the new TelType a bit more add doc for new tel and color types Update tags.rst Update tags.rst Update tags.rst Update tags.rst ...
weaverryan
added a commit
that referenced
this pull request
Nov 16, 2017
…ereguiluz) This PR was merged into the 3.4 branch. Discussion ---------- Improved the first example of the Guard authenticator I don't like the changes I made to this example in #8497. I consider that the new version of the example makes more sense and it's more correct. Commits ------- ad84f23 Improved the first example of the Guard authenticator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #8485.