Deprecated ACL #8477
Merged
Deprecated ACL #8477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Oct 5, 2017
security.rst
Outdated
| @@ -970,6 +969,10 @@ For more details on expressions and security, see :ref:`expressions-security`. | |||
| Access Control Lists (ACLs): Securing individual Database Objects | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
|
|
|||
| .. versionadded:: | |||
There was a problem hiding this comment.
The versionadded directives are missing the version number.
xabbuh
approved these changes
Oct 9, 2017
|
I think https://github.com/symfony/symfony-docs/blob/master/reference/configuration/security.rst should be updated too, all the |
|
@javiereguiluz I agree - can you update the reference section? |
|
I've added a note about ACL deprecation in the security config reference ... and we'll remove it in |
weaverryan
approved these changes
Oct 29, 2017
|
Thanks Javier! I'll keep the issue (#8433) open, because (as you mentioned) we will now need to remove some things from Symfony 4. |
weaverryan
added a commit
that referenced
this pull request
Oct 29, 2017
This PR was squashed before being merged into the 3.4 branch (closes #8477). Discussion ---------- Deprecated ACL This fixes #8433. I've left some mentions to ACLs because they are deprecated, not removed: * Best Practices mentions them: https://symfony.com/doc/current/best_practices/security.html#authorization-i-e-denying-access * Security config reference includes the `acl:` section: https://symfony.com/doc/current/reference/configuration/security.html Commits ------- 3a0cb17 Mention that ACL is deprecated in the security config reference eb4a088 Added version numbers to versionadded directives a94de59 Deprecated ACL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #8433. I've left some mentions to ACLs because they are deprecated, not removed:
acl:section: https://symfony.com/doc/current/reference/configuration/security.html