10000 Update questionhelper.rst by yceruto · Pull Request #8367 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Update questionhelper.rst #8367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Update questionhelper.rst #8367

wants to merge 2 commits into from

Conversation

yceruto
Copy link
Member
@yceruto yceruto commented Sep 7, 2017 •
edited
Loading

Add missed variable $helper in some examples.

@yceruto
Update questionhelper.rst
c1a0395 
Fix undefined variable `$helper`.
@javiereguiluz
Copy link
Member

Not sure about this ... because the previous example doesn't include it either. This $helper var is defined at the very beginning of the article.

@yceruto
Copy link
Member Author
yceruto commented Sep 8, 2017 •
edited
Loading

Well, I could say too, because the next example include it 😄 ...

As I can understand, this article doesn't have a tutorial format, where we always need to start with the first step to complete the rest, so each example is independent and should work as is, plus if each sub-topic is linkable, I didn't like to review the whole article to make it work, it's annoying and boring have to do it... I'd like just copy & paste the code example and see it work, you don't think?

@yceruto
8000 Copy link
Member Author
yceruto commented Sep 8, 2017

I just update other examples, note that were not all, the other half had included ;)

@xabbuh xabbuh added this to the 2.7 milestone Sep 11, 2017
@weaverryan
Copy link
Member

I like this. Thanks @yceruto!

weaverryan added a commit that referenced this pull request Oct 29, 2017
@weaverryan
bug #8367 Update questionhelper.rst (yceruto)
ad2aa31 
This PR was squashed before being merged into the 2.7 branch (closes #8367).

Discussion
----------

Update questionhelper.rst

Add missed variable `$helper` in some examples.

Commits
-------

6128928 Update questionhelper.rst
@weaverryan weaverryan closed this Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed Waiting feedback
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
5 participants
@yceruto @javiereguiluz @weaverryan @xabbuh @carsonbot
0