8000 [PropertyAccess] Document adder and remover support by dunglas · Pull Request #8349 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[PropertyAccess] Document adder and remover support #8349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 22, 2017
Merged

[PropertyAccess] Document adder and remover support #8349

merged 2 commits into from
Sep 22, 2017

Conversation

dunglas
Copy link
Member
@dunglas dunglas commented Sep 5, 2017

No description provided.

xabbuh
xabbuh reviewed Sep 15, 2017
View reviewed changes
components/property_access.rst

The PropertyAccess component checks for methods called ``add<SingularOfThePropertyName>()``
and ``remove<SingularOfThePropertyName>()``. Both methods must be defined.
For instance, in the previous example, the component looks for ``addChild()`` and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...] looks for the [...]

@xabbuh xabbuh added this to the 2.7 milestone Sep 15, 2017
@xabbuh
Copy link
Member
xabbuh commented Sep 22, 2017

Thank you @dunglas.
@xabbuh xabbuh merged commit c62a603 into symfony:2.7 Sep 22, 2017
xabbuh added a commit that referenced this pull request Sep 22, 2017
@xabbuh
minor #8349 [PropertyAccess] Document adder and remover support (dung…
d91e286 
…las, javiereguiluz)

This PR was merged into the 2.7 branch.

Discussion
----------

[PropertyAccess] Document adder and remover support

Commits
-------

c62a603 Minor syntax fixes
e0a6f97 [PropertyAccess] Document adder and remover support
xabbuh added a commit that referenced this pull request Sep 22, 2017
@xabbuh
[#8349] add missing word
3bfd778
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
PropertyAccess Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@dunglas @xabbuh @carsonbot @javiereguiluz
0