Update performance.rst #8332
Update performance.rst #8332
Conversation
Deprecated suggestion
There was a problem hiding this comment.
Great find! Thanks for adding this little note to the docs.
I've added 2 comments where I think this PR can be a little bit updated. If you agree and have some free time, please update your PR (by pushing to the patch-3 branch on your fork). Otherwise, please comment and we'll take care of them! :)
performance.rst
Outdated
| @@ -165,8 +165,12 @@ For more details, see :doc:`/components/class_loader/cache_class_loader`. | |||
| .. index:: | |||
| single: Performance; Bootstrap files | |||
|
|
|||
| Use Bootstrap Files | |||
| ------------------- | |||
| Use Bootstrap Files (For < PHP 7) | |||
There was a problem hiding this comment.
I think we can leave the title as it was
performance.rst
Outdated
|
|
||
| .. note:: | ||
|
|
||
| For PHP 7 and higher versions it is not necessary. It is deprecated for Symfony 4.0. |
There was a problem hiding this comment.
I believe we used caution directives for deprecations in the docs. I think we should also provide a little bit of context to this message, like this:
.. caution::
The performance optimalizations in PHP 7 removed any overhead. As such,
using the bootstrap file is discouraged when using PHP 7+ and was
deprecated in Symfony 4.0. |
@wouterj updated as you requested. @javiereguiluz I just saw your proposal 👍 |
performance.rst
Outdated
|
|
||
| The performance optimalizations in PHP 7 removed any overhead. As such, | ||
| using the bootstrap file is discouraged when using PHP 7+ and was | ||
| deprecated in Symfony 4.0. |
There was a problem hiding this comment.
This was deprecated in 3.3. 4.0 will no longer support the bootstrap files.
This PR was merged into the 3.3 branch. Discussion ---------- Remove outdated performance tips I've just realized there is an ongoing effort to rewrite this in #8410 and #7960. But if those are not merged soon, I'd suggest to merge this first so that we can at least solve the broken doc and people don't try to repeatedly fix this, like me and #8332 Commits ------- d21e200 Remove outdated performance tips
|
Closing it in favor of #9161. |
…onable (javiereguiluz) This PR was squashed before being merged into the 2.7 branch (closes #9161). Discussion ---------- Updated the main performance article to make it more actionable This one finishes and replaces #7960, #8410 and #8332. Commits ------- fa393c5 Updated the main performance article to make it more actionable
Remove deprecated suggestion
See: symfony/symfony#20668